Village Add, Edit and Delete Messages done

controllers/village_controller.py

@@ -83,17 +83,29 @@ def check_village():
     return village.CheckVillage(request=request)
 
 
-# ------------------------- Delete Village -------------------------
 @village_bp.route('/delete_village/<int:village_id>')
 @login_required
 def delete_village(village_id):
-
     village = Village()
     village.DeleteVillage(request=request, village_id=village_id)
 
-    flash(village.resultMessage, "success" if village.isSuccess else "error")
-    return redirect(url_for('village.add_village'))
+    # ✅ Convert resultMessage to string if it's a Response or tuple
+    raw_msg = village.resultMessage
 
+    if isinstance(raw_msg, tuple):
+        # e.g., (<Response ...>, 200)
+        msg = "Village deleted successfully!"
+    elif hasattr(raw_msg, 'get_data'):
+        # Flask Response object
+        msg = raw_msg.get_data(as_text=True)  # get raw text
+    else:
+        # fallback
+        msg = str(raw_msg) if raw_msg else "Village deleted successfully!"
+
+    return jsonify({
+        "status": "success" if village.isSuccess else "error",
+        "message": msg
+    })
 
 # ------------------------- Edit Village -------------------------
 @village_bp.route('/edit_village/<int:village_id>', methods=['GET', 'POST'])

static/js/village.js

@@ -1,264 +1,250 @@
-
-
 window.onload = function () {
-    document.getElementById('Village_Name').focus();
+    if (document.getElementById('Village_Name')) {
+        document.getElementById('Village_Name').focus();
+    }
 };
  
 $(document).ready(function () {
 
-    // 🔥 RESTORE VIEW MODE AFTER RELOAD
-    var viewMode = localStorage.getItem("viewMode");
+    // ✅ RUN ONLY IF THIS PAGE HAS FORM/TABLE
+    if ($('#addForm').length && $('#addTable').length) {
 
-    if (viewMode === "table") {
-        $('#addForm').hide();
-        $('#addTable').show();
-    } else {
+        // ✅ DEFAULT VIEW → SHOW FORM
         $('#addForm').show();
         $('#addTable').hide();
+
+
+        // 🔥 BUTTON TOGGLE
+        $('#addButton').click(function () {
+            $('#addForm').show();
+            $('#addTable').hide();
+        });
+
+        $('#displayButton').click(function () {
+            $('#addForm').hide();
+            $('#addTable').show();
+        });
     }
 
 
-    // 🔥 BUTTON TOGGLE LOGIC
-
-    $('#addButton').click(function () {
-        $('#addForm').show();
-        $('#addTable').hide();
-
-        localStorage.setItem("viewMode", "form");
-    });
-
-    $('#displayButton').click(function () {
-        $('#addForm').hide();
-        $('#addTable').show();
-
-        localStorage.setItem("viewMode", "table");
-    });
-
-
+    // ===============================
     // STATE → DISTRICT
-    $('#state_Id').change(function () {
+    // ===============================
+    if ($('#state_Id').length) {
 
-        var stateId = $(this).val();
+        $('#state_Id').change(function () {
 
-        if (stateId) {
+            var stateId = $(this).val();
 
-            $.ajax({
-                url: '/get_districts/' + stateId,
-                type: 'GET',
+            if (stateId) {
 
-                success: function (data) {
+                $.ajax({
+                    url: '/get_districts/' + stateId,
+                    type: 'GET',
 
-                    var districtDropdown = $('#district_Id');
+                    success: function (data) {
 
-                    districtDropdown.empty();
-                    districtDropdown.append('<option value="" disabled selected>Select District</option>');
+                        var districtDropdown = $('#district_Id');
 
-                    data.forEach(function (district) {
+                        districtDropdown.empty();
+                        districtDropdown.append('<option value="" disabled selected>Select District</option>');
 
-                        districtDropdown.append(
-                            '<option value="' + district.id + '">' + district.name + '</option>'
-                        );
+                        data.forEach(function (district) {
+                            districtDropdown.append(
+                                '<option value="' + district.id + '">' + district.name + '</option>'
+                            );
+                        });
 
-                    });
-
-                    districtDropdown.prop('disabled', false);
-
-                }
-
-            });
-
-        }
-
-    });
+                        districtDropdown.prop('disabled', false);
+                    }
+                });
+            }
+        });
+    }
 
 
+    // ===============================
     // DISTRICT → BLOCK
-    $('#district_Id').change(function () {
+    // ===============================
+    if ($('#district_Id').length) {
 
-        var districtId = $(this).val();
+        $('#district_Id').change(function () {
 
-        if (districtId) {
+            var districtId = $(this).val();
 
-            $.ajax({
-                url: '/get_blocks/' + districtId,
-                type: 'GET',
+            if (districtId) {
 
-                success: function (data) {
+                $.ajax({
+                    url: '/get_blocks/' + districtId,
+                    type: 'GET',
 
-                    var blockDropdown = $('#block_Id');
+                    success: function (data) {
 
-                    blockDropdown.empty();
-                    blockDropdown.append('<option value="" disabled selected>Select Block</option>');
+                        var blockDropdown = $('#block_Id');
 
-                    data.forEach(function (block) {
+                        blockDropdown.empty();
+                        blockDropdown.append('<option value="" disabled selected>Select Block</option>');
 
-                        blockDropdown.append(
-                            '<option value="' + block.id + '">' + block.name + '</option>'
-                        );
+                        data.forEach(function (block) {
+                            blockDropdown.append(
+                                '<option value="' + block.id + '">' + block.name + '</option>'
+                            );
+                        });
 
-                    });
-
-                    blockDropdown.prop('disabled', false);
-
-                }
-
-            });
-
-        }
-
-    });
+                        blockDropdown.prop('disabled', false);
+                    }
+                });
+            }
+        });
+    }
 
 
+    // ===============================
     // VILLAGE NAME VALIDATION
-    $('#Village_Name').on('input', function () {
+    // ===============================
+    if ($('#Village_Name').length) {
 
-        var villageName = $(this).val();
-        var validPattern = /^[A-Za-z ]*$/;
+        $('#Village_Name').on('input', function () {
 
-        if (!validPattern.test(villageName)) {
+            var villageName = $(this).val();
+            var validPattern = /^[A-Za-z ]*$/;
 
-            $('#villageMessage')
-                .text('Only letters and spaces are allowed!')
-                .css('color', 'red');
+            if (!validPattern.test(villageName)) {
 
-            $('#submitVillage').prop('disabled', true);
+                $('#villageMessage')
+                    .text('Only letters and spaces are allowed!')
+                    .css('color', 'red');
 
-        } else {
+                $('#submitVillage').prop('disabled', true);
 
-            $('#villageMessage').text('');
-            $('#submitVillage').prop('disabled', false);
+            } else {
 
-        }
-
-    });
+                $('#villageMessage').text('');
+                $('#submitVillage').prop('disabled', false);
+            }
+        });
+    }
 
 
+    // ===============================
     // CHECK DUPLICATE VILLAGE
-    $('#Village_Name, #block_Id').on('change keyup', function () {
+    // ===============================
+    if ($('#Village_Name').length && $('#block_Id').length) {
 
-        var blockId = $('#block_Id').val();
-        var villageName = $('#Village_Name').val().trim();
+        $('#Village_Name, #block_Id').on('change keyup', function () {
 
-        if (blockId && villageName) {
+            var blockId = $('#block_Id').val();
+            var villageName = $('#Village_Name').val().trim();
 
-            $.ajax({
+            if (blockId && villageName) {
 
-                url: '/check_village',
-                type: 'POST',
+                $.ajax({
+                    url: '/check_village',
+                    type: 'POST',
 
-                data: {
-                    block_Id: blockId,
-                    Village_Name: villageName
-                },
+                    data: {
+                        block_Id: blockId,
+                        Village_Name: villageName
+                    },
 
-                success: function (response) {
+                    success: function (response) {
 
-                    if (response.status === 'exists') {
+                        if (response.status === 'exists') {
+
+                            $('#villageMessage')
+                                .text(response.message)
+                                .css('color', 'red');
+
+                            $('#submitVillage').prop('disabled', true);
+
+                        } else {
+
+                            $('#villageMessage')
+                                .text(response.message)
+                                .css('color', 'green');
+
+                            $('#submitVillage').prop('disabled', false);
+                        }
+                    },
+
+                    error: function () {
 
                         $('#villageMessage')
-                            .text(response.message)
+                            .text('Error checking village name')
                             .css('color', 'red');
 
                         $('#submitVillage').prop('disabled', true);
+                    }
+                });
+            }
+        });
+    }
+
+
+    // ===============================
+    // ADD VILLAGE (SAFE SCOPE FIX)
+    // ===============================
+    if ($('#villageForm').length) {
+
+        $('#villageForm').submit(function (event) {
+
+            event.preventDefault();
+
+            $.ajax({
+                url: '/add_village',
+                type: 'POST',
+                data: $(this).serialize(),
+
+                success: function (response) {
+
+                    if (response && response.status === 'success') {
+
+                        alert(response.message || 'Village added successfully!');
+
+                        // ✅ clear form
+                        $('#villageForm')[0].reset();
+
+                        // ✅ switch to table
+                        $('#addForm').hide();
+                        $('#addTable').show();
+
+                        // optional refresh
+                        location.reload();
 
                     } else {
-
-                        $('#villageMessage')
-                            .text(response.message)
-                            .css('color', 'green');
-
-                        $('#submitVillage').prop('disabled', false);
-
+                        alert(response.message || 'Error adding village. Please try again.');
                     }
-
                 },
 
                 error: function () {
-
-                    $('#villageMessage')
-                        .text('Error checking village name')
-                        .css('color', 'red');
-
-                    $('#submitVillage').prop('disabled', true);
-
+                    alert('An error occurred. Please try again.');
                 }
-
             });
 
-        }
-
-    });
-
-
-    // ADD VILLAGE
-    $('#villageForm').submit(function (event) {
-
-        event.preventDefault();
-
-        $.ajax({
-
-            url: '/add_village',
-            type: 'POST',
-            data: $(this).serialize(),
-
-            success: function (response) {
-
-                if (response.status === 'success') {
-
-                    alert('Village added successfully!');
-                    location.reload();
-
-                } else {
-
-                    alert(response.message || 'Error adding village. Please try again.');
-
-                }
-
-            },
-
-            error: function () {
-
-                alert('An error occurred. Please try again.');
-
-            }
-
         });
-
-    });
+    }
 
 });
 
 
-// 🔥 DELETE FUNCTION (UPDATED)
-function deleteVillage(villageId) {
 
-    if (!confirm("Are you sure you want to delete this village?")) {
-        return;
-    }
 
-    // ✅ save that user is on table
-    localStorage.setItem("viewMode", "table");
+// ===============================
+// DELETE FUNCTION (SAFE)
+// ===============================
+function deleteVillage(villageId, element) {
+    if (!confirm("Are you sure you want to delete this village?")) return;
 
     $.ajax({
         url: '/delete_village/' + villageId,
         type: 'GET',
-
-        success: function () {
-
-            setTimeout(function () {
-
-                alert("Village deleted successfully!");
-
-                // reload but stay on table
-                location.reload();
-
-            }, 1000);
-
+        dataType: 'json',
+        success: function (response) {
+            alert(response.message); // ✅ now shows "Village deleted successfully!"
+            if (element) $(element).closest("tr").remove();
         },
-
         error: function () {
             alert("Error deleting village. Please try again.");
         }
-
     });
 }

templates/add_village.html

@@ -1,99 +1,129 @@
-{% extends 'base.html' %}
-{% block content %}
+{% extends 'base.html' %} {% block content %}
 <head>
-    <meta charset="UTF-8">
-    <meta name="viewport" content="width=device-width, initial-scale=1.0">
-    <title>Village Management</title>
-    <link rel="stylesheet" type="text/css" href="{{ url_for('static', filename='css/style.css') }}">
-    <script src="{{ url_for('static', filename='js/village.js') }}"></script>
-    <script src="{{ url_for('static', filename='js/search_on_table.js') }}"></script>
+  <meta charset="UTF-8" />
+  <meta name="viewport" content="width=device-width, initial-scale=1.0" />
+  <title>Village Management</title>
+  <link
+    rel="stylesheet"
+    type="text/css"
+    href="{{ url_for('static', filename='css/style.css') }}"
+  />
+  <script src="{{ url_for('static', filename='js/village.js') }}"></script>
+  <script src="{{ url_for('static', filename='js/search_on_table.js') }}"></script>
 </head>
 <body>
-
-<!-- Button Container to Center Buttons -->
-<div class="button-container">
+  <!-- Button Container to Center Buttons -->
+  <div class="button-container">
     <button id="addButton" class="action-button">Add</button>
     <button id="displayButton" class="action-button">Display</button>
-</div>
+  </div>
 
-<div id="addForm" style="display: none;">
+  <div id="addForm" style="display: none">
     <div class="container">
-        <div class="form-block">
-            <h2>Add a New Village</h2>
-            <form id="villageForm" method="POST">
-                <label for="state_Id">State:</label>
-                <select id="state_Id" name="state_Id" required>
-                    <option value="" disabled selected>Select State</option>
-                    {% for state in states %}
-                    <option value="{{ state[0] }}">{{ state[1] }}</option>
-                    {% endfor %}
-                </select>
- 
-                <label for="district_Id">District:</label>
-                <select id="district_Id" name="district_Id" required disabled>
-                    <option value="" disabled selected>Select District</option>
-                </select>
+      <div class="form-block">
+        <h2>Add a New Village</h2>
+        <form id="villageForm" method="POST">
+          <label for="state_Id">State:</label>
+          <select id="state_Id" name="state_Id" required>
+            <option value="" disabled selected>Select State</option>
+            {% for state in states %}
+            <option value="{{ state[0] }}">{{ state[1] }}</option>
+            {% endfor %}
+          </select>
 
-                <label for="block_Id">Block:</label>
-                <select id="block_Id" name="block_Id" required disabled>
-                    <option value="" disabled selected>Select Block</option>
-                </select>
+          <label for="district_Id">District:</label>
+          <select id="district_Id" name="district_Id" required disabled>
+            <option value="" disabled selected>Select District</option>
+          </select>
 
-                <label for="Village_Name">Village Name:</label>
-                <input type="text" id="Village_Name" name="Village_Name" placeholder="Enter Village Name" required>
-                <span id="villageMessage"></span>
+          <label for="block_Id">Block:</label>
+          <select id="block_Id" name="block_Id" required disabled>
+            <option value="" disabled selected>Select Block</option>
+          </select>
 
-                <button type="submit" id="submitVillage" disabled>Add Village</button>
-            </form>
-        </div>
+          <label for="Village_Name">Village Name:</label>
+          <input
+            type="text"
+            id="Village_Name"
+            name="Village_Name"
+            placeholder="Enter Village Name"
+            required
+          />
+          <span id="villageMessage"></span>
+
+          <button type="submit" id="submitVillage" disabled>Add Village</button>
+        </form>
+      </div>
     </div>
-</div>
+  </div>
 
-<div id="addTable" style="display: none;">
+  <div id="addTable" style="display: none">
     <div class="search-container">
-        <h2>Display Villages</h2>
-        <input type="text" id="searchBar" placeholder="Searching..." onkeyup="searchTable()">
+      <h2>Display Villages</h2>
+      <input
+        type="text"
+        id="searchBar"
+        placeholder="Searching..."
+        onkeyup="searchTable()"
+      />
     </div>
 
     <table id="sortableTable" border="1">
-        <tr>
-            <th>Village Sr No</th>
-            <th class="sortable-header">
-                Village Name
-                <span class="sort-buttons">
-                        <span class="sort-asc">⬆️</span>
-                        <span class="sort-desc">⬇️</span>
-                    </span></th>
-            <th class="sortable-header">Block Name
-                <span class="sort-buttons">
-                        <span class="sort-asc">⬆️</span>
-                        <span class="sort-desc">⬇️</span>
-                    </span></th>
-            <th>Update</th>
-            <th>Delete</th>
-        </tr>
-        {% for village in villages %}
-        <tr>
-            <td>{{ village[0] }}</td>
-            <td>{{ village[1] }}</td>
-            <td>{{ village[2] }}</td>
-            <td>
-                <a href="{{ url_for('village.edit_village', village_id=village[0]) }}">
-                    <img src="{{ url_for('static', filename='images/icons/pen_blue_icon.png') }}" alt="Edit"
-                         class="icon">
-                </a>
-            </td>
-            <td>
-                <a href="#"
-   onclick="deleteVillage({{ village[0] }}); return false;">
+      <tr>
+        <th>Village Sr No</th>
+        <th class="sortable-header">
+          Village Name
+          <span class="sort-buttons">
+            <span class="sort-asc">⬆️</span>
+            <span class="sort-desc">⬇️</span>
+          </span>
+        </th>
+        <th class="sortable-header">
+          Block Name
+          <span class="sort-buttons">
+            <span class="sort-asc">⬆️</span>
+            <span class="sort-desc">⬇️</span>
+          </span>
+        </th>
+        <th>Update</th>
+        <th>Delete</th>
+      </tr>
+      {% for village in villages %}
+      <tr>
+        <td>{{ village[0] }}</td>
+        <td>{{ village[1] }}</td>
+        <td>{{ village[2] }}</td>
+        <td>
+          <a
+            href="{{ url_for('village.edit_village', village_id=village[0]) }}"
+          >
+            <img
+              src="{{ url_for('static', filename='images/icons/pen_blue_icon.png') }}"
+              alt="Edit"
+              class="icon"
+            />
+          </a>
+        </td>
+        <td>
+       <a href="javascript:void(0);" 
+   onclick="deleteVillage({{ village[0] }}, this)">
     <img src="{{ url_for('static', filename='images/icons/bin_red_icon.png') }}" 
-         alt="Delete" class="icon">
+         class="icon">
 </a>
-            </td>
-        </tr>
-        {% endfor %}
+        </td>
+      </tr>
+      {% endfor %}
     </table>
-</div>
-
+  </div>
+  <!-- Flash Alerts -->
+{% with messages = get_flashed_messages(with_categories=true) %}
+    {% if messages %}
+        <script>
+            {% for category, message in messages %}
+                alert("{{ message }}");
+            {% endfor %}
+        </script>
+    {% endif %}
+{% endwith %}
 </body>
 {% endblock %}

templates/edit_village.html

@@ -28,25 +28,17 @@
 
             <button type="submit">Update Village</button>
         </form>
-    </div>
-
-    <!-- Flash Message (Hidden, used for JS popup) -->
+  <!-- Flash Messages (hidden, used for JS popup) -->
+<div id="flash-messages-container" style="display:none;">
     {% with messages = get_flashed_messages(with_categories=true) %}
-      {% if messages %}
-        {% for category, message in messages %}
-          <div id="flash-message" data-category="{{ category }}" style="display:none;">{{ message }}</div>
-        {% endfor %}
-      {% endif %}
+        {% if messages %}
+            {% for category, message in messages %}
+                <div class="flash-message" data-category="{{ category }}">{{ message }}</div>
+            {% endfor %}
+        {% endif %}
     {% endwith %}
 </div>
 
-<script>
-    window.onload = function () {
-        const flash = document.getElementById('flash-message');
-        if (flash && flash.innerText.trim() !== "") {
-            alert(flash.innerText);
-        }
-    };
-</script>
+
 </body>
 {% endblock %}